4713: Internal Error when trying to save bot with no tool

jcannon

What version of Review Board are you running?

3.0

What version of Review Bot are you running?

1.0

What tool(s) is Review Bot running?

N/A

What steps will reproduce the problem?

  1. Create a new configuration
  2. Give it a name, but don't select a tool
  3. Attempt to save
  4. Notice error

What is the expected output? What do you see instead?

Some error in browser, or not being able to save? See Internal Error instead

Please provide any additional information below.

2018-07-03 16:01:58,556 - INFO -  - root - Reloading logging settings
2018-07-03 16:06:11,834 - INFO -  - root - Reloading logging settings
2018-07-03 16:06:19,823 - INFO -  - root - Reloading logging settings
2018-07-03 16:06:19,914 - ERROR - None - user - /admin/integrations/reviewbotext.integration.ReviewBotIntegration/configs/add/ - djblets.log.middleware - Exception thrown for user user at http://192.168.79.134/admin/integrations/reviewbotext.integration.ReviewBotIntegration/configs/add/
invalid literal for int() with base 10: ''
Traceback (most recent call last):
  File "/opt/bitnami/apps/reviewboardpowerpack/htdocs/venv/lib/python2.7/site-packages/django/core/handlers/base.py", line 112, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/opt/bitnami/apps/reviewboardpowerpack/htdocs/venv/lib/python2.7/site-packages/django/views/generic/base.py", line 69, in view
    return self.dispatch(request, *args, **kwargs)
  File "/opt/bitn
jcannon
#1 jcannon

Review at https://reviews.reviewboard.org/r/10064/

david
#2 david

Fixed in release-1.0.x (8867ce1). This will ship in Review Bot 1.0.1. Thanks!

  • -New
    +Fixed